Browse Source

Clean up empty content fix (revert #4935) (#5539)

Engel Nyst 1 year ago
parent
commit
425ccb0fbb
3 changed files with 2 additions and 10 deletions
  1. 0 8
      openhands/core/message.py
  2. 1 1
      openhands/llm/debug_mixin.py
  3. 1 1
      openhands/llm/fn_call_converter.py

+ 0 - 8
openhands/core/message.py

@@ -105,14 +105,6 @@ class Message(BaseModel):
 
 
         message_dict: dict = {'content': content, 'role': self.role}
         message_dict: dict = {'content': content, 'role': self.role}
 
 
-        # pop content if it's empty
-        if not content or (
-            len(content) == 1
-            and content[0]['type'] == 'text'
-            and content[0]['text'] == ''
-        ):
-            message_dict.pop('content')
-
         if role_tool_with_prompt_caching:
         if role_tool_with_prompt_caching:
             message_dict['cache_control'] = {'type': 'ephemeral'}
             message_dict['cache_control'] = {'type': 'ephemeral'}
 
 

+ 1 - 1
openhands/llm/debug_mixin.py

@@ -16,7 +16,7 @@ class DebugMixin:
         debug_message = MESSAGE_SEPARATOR.join(
         debug_message = MESSAGE_SEPARATOR.join(
             self._format_message_content(msg)
             self._format_message_content(msg)
             for msg in messages
             for msg in messages
-            if msg.get('content', None)
+            if msg['content'] is not None
         )
         )
 
 
         if debug_message:
         if debug_message:

+ 1 - 1
openhands/llm/fn_call_converter.py

@@ -321,7 +321,7 @@ def convert_fncall_messages_to_non_fncall_messages(
     first_user_message_encountered = False
     first_user_message_encountered = False
     for message in messages:
     for message in messages:
         role = message['role']
         role = message['role']
-        content = message.get('content', '')
+        content = message['content']
 
 
         # 1. SYSTEM MESSAGES
         # 1. SYSTEM MESSAGES
         # append system prompt suffix to content
         # append system prompt suffix to content