Browse Source

♻️ refactor(cache): rename append_params to add_params

- change method name for clarity and consistency
- update related test cases to reflect the new method name
awwaawwa 11 months ago
parent
commit
03fd175899
2 changed files with 4 additions and 4 deletions
  1. 2 2
      pdf2zh/cache.py
  2. 2 2
      test/test_cache.py

+ 2 - 2
pdf2zh/cache.py

@@ -57,14 +57,14 @@ class TranslationCache:
         self.params = params
         params = self._sort_dict_recursively(params)
         self.translate_engine_params = json.dumps(params)
-    
+
     def update_params(self, params: dict = None):
         if params is None:
             params = {}
         self.params.update(params)
         self.replace_params(self.params)
 
-    def append_params(self, k: str, v):
+    def add_params(self, k: str, v):
         self.params[k] = v
         self.replace_params(self.params)
 

+ 2 - 2
test/test_cache.py

@@ -138,7 +138,7 @@ class TestCache(unittest.TestCase):
         cache_instance = cache.TranslationCache("test_engine", {"initial": "value"})
 
         # Test appending new parameter
-        cache_instance.append_params("new_param", "new_value")
+        cache_instance.add_params("new_param", "new_value")
         self.assertEqual(cache_instance.params, {"initial": "value", "new_param": "new_value"})
 
         # Test that cache with appended params works correctly
@@ -146,7 +146,7 @@ class TestCache(unittest.TestCase):
         self.assertEqual(cache_instance.get("hello"), "你好")
 
         # Test overwriting existing parameter
-        cache_instance.append_params("initial", "new_value")
+        cache_instance.add_params("initial", "new_value")
         self.assertEqual(cache_instance.params, {"initial": "new_value", "new_param": "new_value"})
 
         # Cache should work with updated params